Hello,
nice to see a team restarting to work on a grib display. Having multiple Grib sources is great.
Now my packaging exercise is not going nicely, I had to do a lot of hacking. Nothing serious but quite a few niggle that will need correction, in order to move xygrib as an official package.
1) Debug symbols
Most Distros do not allow to keep the debug symbols in standard package.
Debug symbol are created by running cmake with the debug option.
I had to strip debugs and deactivate the debug build to pass.
2) Directory
Your executable cannot be installed by make in a directory which is in the executable path, if you are to respect the Linux standards.
It's actually already indicated in your documentation. Needs fixing. Good news, it's simple.
It's easy to correct as we can either use multiple variables in cmake or; as in OpenCPN, use a single prefixvariable and then use /usr/bin and /user/share/xygrib
Currently I need to move the file in the build root before packaging. Pretty ugly.
Man page
a small man page would be nice.
It would avoid an error during packaging check and it would be a great opportunity to add debug and version check options.
--help -h
--version -v
--debug -d
Today, when you have an error, it"s not obvious to know why.
A debug flag would help.
3) .desktop file
You have only done one for Debian, why ?
Why is it not installed ?
It would work.
Today I need a hack in the packaging to get it in the right place.
an icon in svg would be nice as it would allow to support multiple size.
Today we have a ratio screen size to definition which is very variable.
4) New version download
On a boat you do NOT want code with connects on the internet for you.
Update is done when in a harbour, because data at sea are not cheap and update can break your system and you really need it.
e.g. for that reason, I only build for the running OpenSUSE release in my test sandbox but I only publish for stable releases in the official repo.
Furthermore, code is install in a location where you need to be root (admin for Win users), to write anything, so update should fail anyhow.
So my question, is which cmake option, can I use for building without the auto-update feature.
This is for me a show stopper and I will not push it to the main repo, until I have a way to deactivate the feature.
5) Capitalisation
On Linux it"s a PAIN.
It fails search, auto-completion, ...
Could we get only lower case in file names.
6) Reuse my packaging.
You are well come to reuse my packaging a a base for your own tests.
I hope to clean it up once that the previously listed issues are corrected.
My config download master from github at each service run.
You could even trigger a service run each time you do a github commit.
I do not, as I am focussing for secure use at sea.
see
openbuildservice.org/2013/11/22/source-update-via_token/
You can also build for other Linux distros but this is not my focus.
Regards
Dominig